Closed Amulyam24 closed 3 months ago
Name | Link |
---|---|
Latest commit | f7387cc00cba7af52ed5927e742cbd974d70eee1 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66c584b7294650000872e97e |
Deploy Preview | https://deploy-preview-1894--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/hold
@Amulyam24 once you get sometime, Please help in fixing the test failures, We will try to get necessary things done by next week.
@Amulyam24 need to probably also update - https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/3b2125731bb9b77021128f222b165e53f853e6dd/cloudbuild.yaml#L7C5-L7C81 the updated image should have the go 1.22
but I think rc is already released!
/hold cancel
PR is ready for review, PTAL!
/hold
/hold cancel
@mkumatag @Prajyot-Parab PTAL, PR is ready for review.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Amulyam24, mkumatag
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: This PR updates
generate-go-conversions
in Makefile where deprecated flags have been removed/modified afterconversion-gen
version update to v0.30.3Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1884Special notes for your reviewer:
/area provider/ibmcloud
Release note: