kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 84 forks source link

Update cluster-api to v1.8.1 #1894

Closed Amulyam24 closed 3 months ago

Amulyam24 commented 4 months ago

What this PR does / why we need it: This PR updates

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1884

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update cluster-api to v1.8.1
netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit f7387cc00cba7af52ed5927e742cbd974d70eee1
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66c584b7294650000872e97e
Deploy Preview https://deploy-preview-1894--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Amulyam24 commented 4 months ago

/hold

Karthik-K-N commented 3 months ago

@Amulyam24 once you get sometime, Please help in fixing the test failures, We will try to get necessary things done by next week.

Prajyot-Parab commented 3 months ago

@Amulyam24 need to probably also update - https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/3b2125731bb9b77021128f222b165e53f853e6dd/cloudbuild.yaml#L7C5-L7C81 the updated image should have the go 1.22

mkumatag commented 3 months ago

but I think rc is already released!

Amulyam24 commented 3 months ago

/hold cancel

PR is ready for review, PTAL!

Amulyam24 commented 3 months ago

/hold

Amulyam24 commented 3 months ago

/hold cancel

Amulyam24 commented 3 months ago

@mkumatag @Prajyot-Parab PTAL, PR is ready for review.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment