kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 79 forks source link

Configure Loadbalancer back-end pool only for controlplane machines #1990

Open Karthik-K-N opened 3 days ago

Karthik-K-N commented 3 days ago

/kind bug /area provider/ibmcloud

What steps did you take and what happened: [A clear and concise description of what the bug is.]

Creating a IBMPowerVS cluster from cluster-template-powervs-create-infra.yaml template creates a Loadbalancer and configures all the machines of the cluster to its backend pool.

What did you expect to happen:

Only control plane machines should be configured to backendpool as 6443 is APIServer port and only control-plane machines will serve in that port.

Changes needs to be done:

  1. Just skip configuring LB backend pool for data plane nodes here.
  2. Utility function Screenshot 2024-10-04 at 4 08 58 PM

    available in capi repo for identifying machine as control-plane machine

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

Karthik-K-N commented 3 days ago

/good-first-issue

k8s-ci-robot commented 3 days ago

@Karthik-K-N: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1990): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
carmal891 commented 3 days ago

/assign