search

kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 84 forks source link

Add UT for ReconcileVPCSubnet and its subfunctions #2017

Closed Shilpa-Gokul closed 1 month ago

Shilpa-Gokul commented 1 month ago

Add UT for ReconcileVPCSubnet, SetVPCSubnetStatus, checkVPCSubnet, createVPCSubnet functions Partially fixes https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1818

k8s-ci-robot commented 1 month ago

Hi @Shilpa-Gokul. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 66df6e36ab6a76baa97f8d8e3fb61cd4f5f382fd
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/671b9e8157d0bb00088cdfe4
Deploy Preview https://deploy-preview-2017--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Amulyam24 commented 1 month ago

/ok-to-test

Shilpa-Gokul commented 1 month ago

@Karthik-K-N @Prajyot-Parab @Amulyam24 Have addressed all the comments, could you please review again?

Prajyot-Parab commented 1 month ago

@Shilpa-Gokul Is this dependent on any of the other PRs you are working on or ready to merge? /cc @Amulyam24

Shilpa-Gokul commented 1 month ago

@Shilpa-Gokul Is this dependent on any of the other PRs you are working on or ready to merge? /cc @Amulyam24

@Prajyot-Parab This is not dependent on any other PRs and is ready to merge.

Shilpa-Gokul commented 1 month ago

@Prajyot-Parab @Amulyam24 @Karthik-K-N Have addressed all the comments, please take a look

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [Prajyot-Parab] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment