search

kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 84 forks source link

Use ignition only when Ignition is set in IBMPowerVSCluster #2037

Closed Karthik-K-N closed 2 weeks ago

Karthik-K-N commented 2 weeks ago

What this PR does / why we need it:

This PR allows to create cos bucket and push ignition data to it only when IBMPowerVSCluster.Spec.Ignition is set because COS Instance is created only when this is set.

Even if user data format is ignition and IBMPowerVSCluster.Spec.Ignition is nil, the code will eventually fail to fetch cos instance as it might not be created.

Removed create infra anotation checks in machine controller as it might not needed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

netlify[bot] commented 2 weeks ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 56178e53d1c867a1bfb0ff9dc4254efff22a437b
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/672b368b6ca030000850690a
Deploy Preview https://deploy-preview-2037--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Karthik-K-N commented 2 weeks ago

/hold

Trying to see if some rearrange of code might fix the issue.

Karthik-K-N commented 2 weeks ago

Ready for review. Will unhold after some testing.

k8s-ci-robot commented 2 weeks ago

@Karthik-K-N: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-ibmcloud-apidiff 56178e53d1c867a1bfb0ff9dc4254efff22a437b link false /test pull-cluster-api-provider-ibmcloud-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Karthik-K-N, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment