Closed cjschaef closed 3 days ago
Hi @cjschaef. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | b067adec698f4ce1f06c906c2c343bc3bb22bb92 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/673b5ce5dbeae600086a50fb |
Deploy Preview | https://deploy-preview-2042--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
/assign @Prajyot-Parab
LGTM from my side. Thanks
@Prajyot-Parab can you please review this PR?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cjschaef, Prajyot-Parab
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
Thanks @Prajyot-Parab @Karthik-K-N
What this PR does / why we need it: Support additional options and utilize the extended VPC Infrastructure (Network Status) options for VPC Machine reconciliation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes # https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1977Special notes for your reviewer:
/area provider/ibmcloud
Release note: