kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 77 forks source link

Use the pkg/cloud/services for the vpc #532

Closed mkumatag closed 2 years ago

mkumatag commented 2 years ago

/kind feature /area provider/ibmcloud

Describe the solution you'd like Currently VPC client is in https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/cloud/scope/clients.go, this needs to be moved to pkg/cloud/service to have mocking and better code maintenance.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

mkumatag commented 2 years ago

/assign @Amulyam24