Copy Kubeadm userdata secret labels to CAPK secret.

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt

Apache License 2.0

110 stars 63 forks source link

Copy Kubeadm userdata secret labels to CAPK secret. #164

Closed pjaton closed 2 years ago

pjaton commented 2 years ago

What this PR does / why we need it:

This ensures that the ...-userdata secret CAPK creates to enhance the cloud-init user data generated by Kubeadm has the same label(s) that the latter.

Currently, this results in these secrets getting the cluster.x-k8s.io/cluster-name=<cluster-name> label.

Which issue this PR fixes:

fixes #161

Release notes:

NONE

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2753969306

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 46.327%

Totals
Change from base Build 2742217302:	0.03%
Covered Lines:	719
Relevant Lines:	1552

💛 - Coveralls

agradouski commented 2 years ago

/ok-to-test

agradouski commented 2 years ago

/lgtm

agradouski commented 2 years ago

/lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, pjaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment