Closed qinqon closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/kubevirt/utils.go | 14 | 16 | 87.5% | ||
<!-- | Total: | 14 | 16 | 87.5% | --> |
Totals | |
---|---|
Change from base Build 3154490540: | 0.3% |
Covered Lines: | 965 |
Relevant Lines: | 1865 |
There is a chicken egg issue, we need to create one NNCP per tenant cluster + node since it will contain the specific ip for that tenant cluster and for that we need to know where the VMI machine is going to run but the VMI depends on the bridge to be created or the virt-launcher pod will be on "Scheduling" forever.
We have to configure all the infra workers nodes where VMIs will run with the bridge and an IPs from the ipamer, that should be done at KubevirtCluster reconcile.
/ok-to-test
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qinqon
Once this PR has been reviewed and has the lgtm label, please assign agradouski for approval by writing /assign @agradouski
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@qinqon: PR needs rebase.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
What this PR does / why we need it: Hammer the infra to have one controller one worker tenant cluster using secondary interfaces + bridge cni + nmstate
TODO:
FIXME:
Release notes: