kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
110 stars 63 forks source link

spike: Set worker networkings secondary #185

Closed qinqon closed 1 year ago

qinqon commented 2 years ago

What this PR does / why we need it: Hammer the infra to have one controller one worker tenant cluster using secondary interfaces + bridge cni + nmstate

TODO:

FIXME:

Release notes:

NONE
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 3204954945


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kubevirt/utils.go 14 16 87.5%
<!-- Total: 14 16 87.5% -->
Totals Coverage Status
Change from base Build 3154490540: 0.3%
Covered Lines: 965
Relevant Lines: 1865

💛 - Coveralls
qinqon commented 1 year ago

There is a chicken egg issue, we need to create one NNCP per tenant cluster + node since it will contain the specific ip for that tenant cluster and for that we need to know where the VMI machine is going to run but the VMI depends on the bridge to be created or the virt-launcher pod will be on "Scheduling" forever.

We have to configure all the infra workers nodes where VMIs will run with the bridge and an IPs from the ipamer, that should be done at KubevirtCluster reconcile.

qinqon commented 1 year ago

/ok-to-test

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qinqon Once this PR has been reviewed and has the lgtm label, please assign agradouski for approval by writing /assign @agradouski in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

@qinqon: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten