search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

kubevirtci: Refactor fetch mechanism #191

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it: Everytime kubevirtci is call a fetch is run this is totally unnecesary and somtimes it fails, this change refactor the fetch to do it when necessary and also move the kubevirtci cloned path to .kubevirtci.

NONE
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3204473078

Totals Coverage Status
Change from base Build 3154490540: 0.0%
Covered Lines: 952
Relevant Lines: 1850
💛 - Coveralls
nunnatsa commented 1 year ago

/ok-to-test

davidvossel commented 1 year ago

/approve /retest

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidvossel commented 1 year ago

I made a smaller ubuntu k8s 1.23.10 image that i'm testing here, https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/193, to see if it helps the persistent VM test failures

qinqon commented 1 year ago

I made a smaller ubuntu k8s 1.23.10 image that i'm testing here, #193, to see if it helps the persistent VM test failures

Maybe we should use ubuntu-cloud instead of ubuntu-server