Closed fengye87 closed 1 year ago
Welcome @fengye87!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/ok-to-test
/retest
@fengye87 thanks for the fix. just wondering, did you observe the actual issue related to this fix? do you mind adding details to this PR of how to reproduce?
Totals | |
---|---|
Change from base Build 3154490540: | 0.0% |
Covered Lines: | 952 |
Relevant Lines: | 1850 |
@agradouski This is an obvious typo in the template file. I found it when I was trying capv and I manually fixed the typo before using the template and it worked. I haven't tried with the original template, it may or may not work, but I think this typo is very obvious.
/retest
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: davidvossel, fengye87
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: