kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

dnm: Use multus as primary interface #201

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qinqon Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval by writing /assign @fabriziopandini in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 1 year ago

CLA Not Signed

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3295187067


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kubevirt/utils.go 13 15 86.67%
pkg/ssh/ssh_command_executor.go 0 4 0.0%
pkg/kubevirt/machine.go 18 23 78.26%
controllers/kubevirtcluster_controller.go 2 10 20.0%
api/v1alpha1/zz_generated.deepcopy.go 0 18 0.0%
<!-- Total: 43 80 53.75% -->
Files with Coverage Reduction New Missed Lines %
pkg/kubevirt/machine_factory.go 2 0%
pkg/infracluster/infracluster.go 5 87.23%
api/v1alpha1/kubevirtcluster_types.go 6 33.33%
pkg/kubevirt/utils.go 9 81.58%
pkg/ssh/ssh_command_executor.go 9 0%
pkg/kubevirt/machine.go 24 62.58%
controllers/kubevirtcluster_controller.go 43 44.91%
api/v1alpha1/zz_generated.deepcopy.go 79 0%
controllers/kubevirtmachine_controller.go 110 62.65%
<!-- Total: 287 -->
Totals Coverage Status
Change from base Build 3292711062: 0.0%
Covered Lines: 952
Relevant Lines: 1850

💛 - Coveralls