Closed hiromu-a5a closed 1 year ago
Welcome @hiromu-a5a!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/lgtm
Totals | |
---|---|
Change from base Build 3313966163: | 0.0% |
Covered Lines: | 952 |
Relevant Lines: | 1850 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: davidvossel, hiromu-a5a
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
Added a document for PCI passthrough configuration on CAPK to avoid unnecessary trial and error. Although we can find a clue from KubeVirt document, to make the entire steps clear, would like to suggest adding the document to CAPK.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #192Special notes for your reviewer: I think the release notes are not needed for this small change. If needed, please let me know.
Release notes:
NONE