Closed rhrazdil closed 1 year ago
Totals | |
---|---|
Change from base Build 3465063271: | 0.0% |
Covered Lines: | 952 |
Relevant Lines: | 1850 |
/ok-to-test
The CI is failing on something that's not related to this PR, however, there is another issue it seems. The test gets pass the VM restart, so that works fine, but fails at this step (when running locally):
By("wait for a new VMI to be created")
For some reason, the VM is stopped, so the VMI is never re-created. I'm not sure what causes it. I suspected the drain, but I'm failing to reproduce it locally. @davidvossel
I found the issue why the test was failing for me locally. For some reason, the test finalizer removed at this step is not actually removed from the VMI.
ci is unfortuantely broken due a switch to podman that occurred recently. @nunnatsa is addressing these issues in pr https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/207
There's apparently another flake when creating a client, but the CI has passed with the updated ubuntu image https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubernetes-sigs_cluster-api-provider-kubevirt/206/pull-kubernetes-sigs-cluster-api-provider-kubevirt-e2e/1592517095147442176
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: davidvossel, rhrazdil
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Updated the ubuntu image
The updated ubuntu image was merged. This should be safe to merge now, wdyt @davidvossel ?
/hold cancel /lgtm
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release notes: