Remove the IMAGE_REPO env var from all the temlates

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt

Apache License 2.0

108 stars 61 forks source link

Remove the IMAGE_REPO env var from all the temlates #207

Closed nunnatsa closed 1 year ago

nunnatsa commented 1 year ago

cluster-api project wants to stop using the k8s.gcr.io repository, as it's too expensive. After checking in other cluster API project, it seems that this value is no longer in the template.

This PR removes all the usage in IMAGE_REPO variable; for that, the PR also upgrade the clusterctl in the kubevirtci script, to v1.2.4

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

None

nunnatsa commented 1 year ago

/ok-to-test

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3461882116

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.459%

Totals
Change from base Build 3381269910:	0.0%
Covered Lines:	952
Relevant Lines:	1850

💛 - Coveralls

davidvossel commented 1 year ago

another podman issue. this time with pushing the locally built capk to the internal registry

docker push 127.0.0.1:33847/capk-manager-amd64:dev
Getting image source signatures
Copying blob sha256:0b1d42bd476085ada536f7e14b02dab4d4c4172f3131bea3ba213d67c7efbd07
Copying blob sha256:9fce6bd02a21068901a96271d3160c2ce9da9c83c152eeb22312f65226da108c
Error: trying to reuse blob sha256:9fce6bd02a21068901a96271d3160c2ce9da9c83c152eeb22312f65226da108c at destination: pinging container registry 127.0.0.1:33847: Get "https://127.0.0.1:33847/v2/": http: server gave HTTP response to HTTPS client

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel,nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment