kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Allow podman to push images to insecure kubevirtci registry #208

Closed brianmcarey closed 1 year ago

brianmcarey commented 1 year ago

Signed-off-by: Brian Carey bcarey@redhat.com

What this PR does / why we need it: These changes are required to run the e2e test job under podman. Kubevirt CI has been working on moving all jobs to run under podman and the old docker in docker setup will no longer be supported.

Add the insecure kubevirtci registry to registries.conf when using podman to push images to the registry. Currently this fails in CI as podman is unable to push to insecure registries by default.

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubernetes-sigs_cluster-api-provider-kubevirt/207/pull-kubernetes-sigs-cluster-api-provider-kubevirt-e2e/1592063138562314240#1:build-log.txt%3A510

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

NONE
k8s-ci-robot commented 1 year ago

Welcome @brianmcarey!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

nunnatsa commented 1 year ago

/ok-to-test

nunnatsa commented 1 year ago

/lgtm

cchengleo commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey, cchengleo, davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [cchengleo,davidvossel,nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3462567482


Totals Coverage Status
Change from base Build 3462320903: 0.0%
Covered Lines: 952
Relevant Lines: 1850

💛 - Coveralls
davidvossel commented 1 year ago

/lgtm