kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

release: Add all the cluster template flavors #209

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it: There were missing template flavors at the github release used when a user generate a cluster with --infrastructure kubevirt, this change add all of the flavors and also check that the kccm ones are generated.

Special notes for your reviewer: The github action has being refactored for simplicity

Release notes:

Add all the cluster flavors
qinqon commented 1 year ago

/cc @nunnatsa

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3564939903


Totals Coverage Status
Change from base Build 3546440746: 0.0%
Covered Lines: 952
Relevant Lines: 1850

💛 - Coveralls
k8s-triage-robot commented 1 year ago

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla /easycla

qinqon commented 1 year ago

/ok-to-test

nunnatsa commented 1 year ago

Now I see that this is the reason that the check-gen lane has failed.

qinqon commented 1 year ago

Now I see that this is the reason that the check-gen lane has failed.

Fixed @nunnatsa can you take another view ?

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nunnatsa commented 1 year ago

/lgtm