Spike guest dhcp companion proxy arp

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt

Apache License 2.0

108 stars 61 forks source link

Spike guest dhcp companion proxy arp #210

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it:

Spike to test proxy-arp to enrute traffic to virt-launcher using proxy-arp so only one interface is preseent at the guest VM

[x] clusterip or loadbalancerip traffic does not enter the virt-proxy bridge port
- kubeveirtci issue, set bridge-nf-call-* at nodes -> https://wiki.libvirt.org/page/Net.bridge.bridge-nf-call_and_sysctl.conf
```
sysctl -w net.bridge.bridge-nf-call-arptables=0
sysctl -w net.bridge.bridge-nf-call-iptables=0
sysctl -w net.bridge.bridge-nf-call-ip6tables=0
```
[ ] after live migration the VM is not able to resolve names
- dns resolv is the dnsmasq ip and it changes with whereabouts
- expose dnsmasq tcp/53 as a service

Special notes for your reviewer: Depends-on:

https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/203

Release notes:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qinqon Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval by writing /assign @justinsb in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

k8s-ci-robot commented 1 year ago

@qinqon: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

davidvossel commented 1 year ago

/close

k8s-ci-robot commented 1 year ago

@davidvossel: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/210#issuecomment-1478064567): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.