kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
110 stars 63 forks source link

Introduce cluster template with Passt binding #213

Closed rhrazdil closed 1 year ago

rhrazdil commented 1 year ago

What this PR does / why we need it: This PR adds template with VMs using Passt binding to pod network. Passt featureGate is enabled in kubevirtci script and Passt recommended node configuration is performed on cluster-up.

NOTE: There is a commit bumping kubevirt to 0.59.0-alpha, because while https://github.com/kubevirt/kubevirt/pull/8578 is merged in kubevirt release-0.58 branch, the change hasn't made it to v0.58.0 tag.

Lastly, an e2e test is added to exercise cluster creation with Passt binding.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3581237415


Totals Coverage Status
Change from base Build 3575808597: 0.0%
Covered Lines: 952
Relevant Lines: 1850

💛 - Coveralls
davidvossel commented 1 year ago

/ok-to-test

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidvossel commented 1 year ago

/lgtm