kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Allow usage of namespace in controlPlaneServiceTemplate #220

Closed aamoyel closed 1 year ago

aamoyel commented 1 year ago

Fix #219

linux-foundation-easycla[bot] commented 1 year ago

CLA Missing ID CLA Not Signed

k8s-ci-robot commented 1 year ago

Welcome @aamoyel!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

davidvossel commented 1 year ago

/ok-to-test

cchengleo commented 1 year ago

/ok-to-test

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aamoyel, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aamoyel commented 1 year ago

I've complete CLA many times as individual contributor but after redirect i can't see changes on this PR. I've seen a network error in prow ci "test" job, It's possible to start a new ?

agradouski commented 1 year ago

/lgtm

davidvossel commented 1 year ago

/retest EasyCLA

k8s-ci-robot commented 1 year ago

@davidvossel: No presubmit jobs available for kubernetes-sigs/cluster-api-provider-kubevirt@main

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/220#issuecomment-1458455426): >/retest EasyCLA Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
davidvossel commented 1 year ago

@aamoyel sorry about the EasyCLA check. We can't seem to get it to retest. Would you be able to try opening a new PR and see if EasyCLA passes?

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4356288605


Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/kubevirtcluster_controller.go 1 3 33.33%
<!-- Total: 1 3 33.33% -->
Totals Coverage Status
Change from base Build 4186617146: -0.03%
Covered Lines: 953
Relevant Lines: 1811

💛 - Coveralls
aamoyel commented 1 year ago

@aamoyel sorry about the EasyCLA check. We can't seem to get it to retest. Would you be able to try opening a new PR and see if EasyCLA passes?

No problem, yeah, i will close the PR to opening a new one.