Closed aamoyel closed 1 year ago
Welcome @aamoyel!
It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/ok-to-test
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aamoyel, davidvossel
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I've complete CLA many times as individual contributor but after redirect i can't see changes on this PR. I've seen a network error in prow ci "test" job, It's possible to start a new ?
/lgtm
/retest EasyCLA
@davidvossel: No presubmit jobs available for kubernetes-sigs/cluster-api-provider-kubevirt@main
@aamoyel sorry about the EasyCLA check. We can't seem to get it to retest. Would you be able to try opening a new PR and see if EasyCLA passes?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
controllers/kubevirtcluster_controller.go | 1 | 3 | 33.33% | ||
<!-- | Total: | 1 | 3 | 33.33% | --> |
Totals | |
---|---|
Change from base Build 4186617146: | -0.03% |
Covered Lines: | 953 |
Relevant Lines: | 1811 |
@aamoyel sorry about the EasyCLA check. We can't seem to get it to retest. Would you be able to try opening a new PR and see if EasyCLA passes?
No problem, yeah, i will close the PR to opening a new one.
Fix #219