search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Kubevirt CRD are mandatory even in a remote kubevirt provider setup #221

Closed BarthV closed 5 months ago

BarthV commented 1 year ago

Hi everyone ! :)

What steps did you take and what happened:

Result :

CAPK logs :

E0125 16:46:16.363348       1 logr.go:279] controller-runtime/source "msg"="if kind is a CRD, it should be installed before calling Start" "error"="no matches for kind \"VirtualMachine\" in version \"kubevirt.io/v1\""  "kind"={"Group":"kubevirt.io","Kind":"VirtualMachine"}

E0125 16:46:18.566683       1 logr.go:279] controller-runtime/source "msg"="if kind is a CRD, it should be installed before calling Start" "error"="no matches for kind \"VirtualMachineInstance\" in version \"kubevirt.io/v1\""  "kind"={"Group":"kubevirt.io","Kind":"VirtualMachineInstance"}

What did you expect to happen:

CAPK provider is able to manage remote VM without requiring local kubevirt CRD to be injected as a prerequisite. CAPK provider should probably embed kubevirt CRD and manage its own dependencies and CAPK/kubevirt compatibility matrix.

Environment:

/kind bug

related issues : 100

BarthV commented 1 year ago

Embedding kubevirt CRD inside this provider is not an easy work, especially if we target to manage multiple kubevirt CRD version in parallel.

It's not a simple topic but I think we should clarify a bit how things are working in a remote setup & what are the requirements against kubevirt on the capi cluster.

The best awnser would probably to split the internal kubernetes client dedicated to local clusterapi from the client dedicated to kubevirt operations. Using the same client (the one used by this controller for reach its own local API) is maybe not the best design here IMO.

cchengleo commented 1 year ago

https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/issues/100 also mentioned the same issue

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/issues/221#issuecomment-1899352306): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.