kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Remove kube-rbac-proxy #222

Closed yuanchen8911 closed 1 year ago

yuanchen8911 commented 1 year ago

What this PR does / why we need it:

Following the upstream cluster-api instruction, remove unneeded component kube-rbac-proxy.

Which issue this PR fixes

Remove uneeded kube-rbac-proxy.

Special notes for your reviewer:

Tested the changes locally to bring up capi controller managers and capk controller managers.

[yuanchen:~/projects/aci/go/cluster-api-provider-kubevirt/e2e]$ kubectl get pods -A
NAMESPACE                           NAME                                                            READY   STATUS    RESTARTS      AGE
capi-kubeadm-bootstrap-system       capi-kubeadm-bootstrap-controller-manager-64fcd4ff4d-p6jgh      1/1     Running   0             6m41s
capi-kubeadm-control-plane-system   capi-kubeadm-control-plane-controller-manager-6f86697dc-jmn8f   1/1     Running   0             6m40s
capi-system                         capi-controller-manager-7847d5c678-8gqbh                        1/1     Running   0             6m41s
capk-system                         capk-controller-manager-67c486ffd6-wm4h4                        2/2     Running   2 (72s ago)   5m37s
cert-manager                        cert-manager-6dc4964c9-gp2kg                                    1/1     Running   0             7m3s
cert-manager                        cert-manager-cainjector-69d4647c6-fdzmx                         1/1     Running   0             7m3s
cert-manager                        cert-manager-webhook-75f77865c8-4b7dq                           1/1     Running   0             7m3s
kube-system                         coredns-565d847f94-kvbc6                                        1/1     Running   0             28m
kube-system                         coredns-565d847f94-zghlh                                        1/1     Running   0             28m
kube-system                         etcd-kubevirt-control-plane                                     1/1     Running   0             29m
kube-system                         kindnet-vjtk5                                                   1/1     Running   0             29m
kube-system                         kube-apiserver-kubevirt-control-plane                           1/1     Running   0             29m
kube-system                         kube-controller-manager-kubevirt-control-plane                  1/1     Running   0             29m
kube-system                         kube-proxy-vxtxb                                                1/1     Running   0             29m
kube-system                         kube-scheduler-kubevirt-control-plane                           1/1     Running   0             29m
local-path-storage                  local-path-provisioner-684f458cdd-sgrm6                         1/1     Running   0             2

Release notes:

Remove kube-rbac-proxy 
yuanchen8911 commented 1 year ago

/cc @cchengleo

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4057721529


Totals Coverage Status
Change from base Build 3882884209: 0.0%
Covered Lines: 952
Relevant Lines: 1808

💛 - Coveralls
yuanchen8911 commented 1 year ago

/cc @agradouski

cchengleo commented 1 year ago

/ok-to-test

cchengleo commented 1 year ago

/LGTM

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agradouski, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [agradouski] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment