search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Use nocloud when specified #224

Closed hh closed 12 months ago

hh commented 1 year ago

We are picking this up from @BobyMCbobs (thanks for the work on this) Context: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/212

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hh Once this PR has been reviewed and has the lgtm label, please assign agradouski for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4169745530

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kubevirt/machine.go 2 4 50.0%
pkg/kubevirt/utils.go 36 52 69.23%
<!-- Total: 38 56 67.86% -->
Files with Coverage Reduction New Missed Lines %
pkg/kubevirt/utils.go 2 73.94%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 4069808194: -0.2%
Covered Lines: 964
Relevant Lines: 1838
💛 - Coveralls
hh commented 1 year ago

Ensuring we loop in @davidvossel

someone could theoretically set a CloudInitConfigDrive volume too. I don't like that this logic is assuming that only a CloudInitNoCloud volume get's the special behavior.

making the default cloudInitConfigDrive is good though

I'm comfortable merging this once the mergo logic is replaced.

davidvossel commented 1 year ago

/ok-to-test

davidvossel commented 1 year ago

this comment [1] from the previous pr was the primary remaining thing. We don't have to remove mergo from go.mod since i know it's an indirect dependency somewhere in the dependency chain. I'd just like to see that we dont' introduce that dependency directly in the capk code for this PR simply because it isn't needed.

  1. https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/212#discussion_r1047755256
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 12 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 12 months ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/224#issuecomment-1636068872): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the PR is closed > >You can: >- Reopen this PR with `/reopen` >- Mark this PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.