Add the ginkgolinter and fix findings

[nunnatsa]

In addition to the ginkgo linter findings, replace this pattern:

err = funcRetErr()
Expect(err).ToNot(HaveOccurred())

With the more readable version of:

Expect(funcRetErr()).To(Succeed())

Improve some Eventually usages by using the Gomega parameter instead of returning error, to get cleaner test code.

Also, replaced some deprecation methods.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release notes:

None

[coveralls]

Pull Request Test Coverage Report for Build 4181316724

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 52.655%

---

Totals
Change from base Build 4069808194:	0.0%
Covered Lines:	952
Relevant Lines:	1808

---

💛 - Coveralls

[nunnatsa]

/ok-to-test

[davidvossel]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel,nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment