kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

feat: add condition to controlPlaneServiceTemplate in KubevirtCluster… #227

Closed aamoyel closed 1 year ago

aamoyel commented 1 year ago

Fix #219

linux-foundation-easycla[bot] commented 1 year ago

CLA Missing ID CLA Not Signed

aamoyel commented 1 year ago

I think i need to change my git commit email to match userID with easycla. Sorry for the miss.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aamoyel Once this PR has been reviewed and has the lgtm label, please assign agradouski for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment