search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

feat: add condition to controlPlaneServiceTemplate in KubevirtCluster… #228

Closed aamoyel closed 1 year ago

aamoyel commented 1 year ago

Fix #219

agradouski commented 1 year ago

/lgtm

agradouski commented 1 year ago

please add testing details to the PR description, and, ideally, a unit test

davidvossel commented 1 year ago

/ok-to-test

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4595786774

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/kubevirtcluster_controller.go 1 3 33.33%
<!-- Total: 1 3 33.33% -->
Totals Coverage Status
Change from base Build 4542574610: -0.03%
Covered Lines: 947
Relevant Lines: 1805
💛 - Coveralls
aamoyel commented 1 year ago

What can i do to make this PR approved ? All tests are green to me.

aamoyel commented 1 year ago

Re open for merge. Sorry for the miss.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aamoyel Once this PR has been reviewed and has the lgtm label, please ask for approval from agradouski. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
agradouski commented 1 year ago

the fix looks good - let's make sure we have it tested, and ideally integrated in our automated testing process. @aamoyel - can we add an integration test for this?