kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

condition to use controlPlaneEndpoint values #232

Closed aamoyel closed 1 year ago

aamoyel commented 1 year ago

Fix #218

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aamoyel Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
agradouski commented 1 year ago

/lgtm

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4598366393


Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/kubevirtcluster_controller.go 2 7 28.57%
<!-- Total: 2 7 28.57% -->
Files with Coverage Reduction New Missed Lines %
controllers/kubevirtcluster_controller.go 1 43.68%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 4542574610: -0.1%
Covered Lines: 947
Relevant Lines: 1809

💛 - Coveralls