search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

feat: add condition to controlPlaneServiceTemplate in KubevirtCluster… #235

Closed aamoyel closed 1 year ago

aamoyel commented 1 year ago

Fix #219

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4869775871

Totals Coverage Status
Change from base Build 4542574610: 0.2%
Covered Lines: 955
Relevant Lines: 1811
💛 - Coveralls
agradouski commented 1 year ago

/retest

agradouski commented 1 year ago

@aamoyel - looks like we have a failing test, please take a look

aamoyel commented 1 year ago

@aamoyel - looks like we have a failing test, please take a look

Sorry, i've forget to gen CRD's manifests, i've pushed the new version of config/crd/bases/infrastructure.cluster.x-k8s.io_kubevirtclusters.yaml file. Can you retry tests ?

davidvossel commented 1 year ago

/ok-to-test

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aamoyel, agradouski, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [agradouski,davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment