search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Update to golang 1.20 #249

Closed davidvossel closed 10 months ago

davidvossel commented 11 months ago

updates to use golang 1.20.6, the latest stable golang release

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
agradouski commented 11 months ago

/ok-to-test

agradouski commented 11 months ago

@davidvossel looks like build / check-gen check is failing

agradouski commented 11 months ago

otherwise, /lgtm

nunnatsa commented 10 months ago

@davidvossel - I missed this PR. Sorry. done in #257

/close

k8s-ci-robot commented 10 months ago

@nunnatsa: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/249#issuecomment-1686185867): >@davidvossel - I missed this PR. Sorry. done in #257 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 10 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.