search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Add KubevirtClusterTemplate resource to support ClusterClass feature #251

Closed aamoyel closed 10 months ago

aamoyel commented 11 months ago

Fix: #250

agradouski commented 11 months ago

/ok-to-test

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 5985539652

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1alpha1/zz_generated.deepcopy.go 0 63 0.0%
<!-- Total: 4 67 5.97% -->
Totals Coverage Status
Change from base Build 5940382564: -1.6%
Covered Lines: 926
Relevant Lines: 1871
💛 - Coveralls
agradouski commented 11 months ago

@davidvossel note, this is an alpha feature of CAPI, any objections to support it in CAPK at this time?

agradouski commented 11 months ago

/lgtm

linux-foundation-easycla[bot] commented 10 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

nunnatsa commented 10 months ago

/hold

github action CI didn't run yet.

davidvossel commented 10 months ago

/hold cancel

nunnatsa commented 10 months ago

/hold

The ci was not run yet

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aamoyel, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidvossel commented 10 months ago

github action CI didn't run yet.

oh? I see that the e2e integration test passed. What else are we waiting on?

nunnatsa commented 10 months ago

github action CI didn't run yet.

oh? I see that the e2e integration test passed. What else are we waiting on?

Unit tests, linters, check-gen, etc.

Admins should see the "Approve and Test" button. Clicking on it will enable these tests

nunnatsa commented 10 months ago

github action CI didn't run yet.

oh? I see that the e2e integration test passed. What else are we waiting on?

Unit tests, linters, check-gen, etc.

Admins should see the "Approve and Test" button. Clicking on it will enable these tests

@agradouski @cchengleo ^^^

aamoyel commented 10 months ago

Can you replay tests please @agradouski @davidvossel ?

nunnatsa commented 10 months ago

/unhold

Thanks @aamoyel !

nunnatsa commented 10 months ago

/lgtm