kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

fix(api): default value for KubeVirtCluster.status.ready field #253

Closed prometherion closed 10 months ago

prometherion commented 11 months ago

What this PR does / why we need it:

It sets a default value for the KubeVirtCluster.status.ready field, suppressing the annoying values when updating for the first time KubeVirtCluster.

Which issue this PR fixes: fixes #252

Special notes for your reviewer:

Although this changes the specification, thus requiring a minor bump, the API change is absolutely minimal and could be considered a patch one.

Release notes:

NONE
k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, prometherion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidvossel commented 10 months ago

/ok-to-test

maxheyer commented 10 months ago

When do you think new versions will be released? Since this bug prevents new clusters from being created.