kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

fix: api reader for CCM clean-up to avoid cache lazy loading #255

Closed prometherion closed 10 months ago

prometherion commented 11 months ago

What this PR does / why we need it:

Cache lazy loading is disabled when the API Reader client is getting or listing objects, as the opposite with the manager client.

Which issue this PR fixes:

fixes #254

Special notes for your reviewer:

Release notes:

NONE
davidvossel commented 10 months ago

/ok-to-test

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, prometherion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
davidvossel commented 10 months ago

/hold cancel