Closed prometherion closed 10 months ago
@prometherion - #257 was just merged, bumping golang to version 1.20
Could you please try again with the latest version of golangci-lint?
/retest
/ok-to-test
/hold
Need to run ci
@davidvossel I think there is a button for admins to allow ci to run. Could you please check?
@prometherion, could you please update PR title with the right version of golangci-lint?
/hold
Need to run ci
@davidvossel I think there is a button for admins to allow ci to run. Could you please check?
@agradouski @cchengleo - could you do that?
/lgtm
@prometherion - the setting of this repo require one-time approval from an admin. This is why the github actions are not running. The funny thing is that it's is possible to merge even without it... Let's wait for one of the admins to approve you as a contributor.
/approve
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nunnatsa, prometherion, qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
What this PR does / why we need it:
Currently, there's no version pinning for the
golangci-lint
utility used, I had to manually retrieve it.Rather, having it declared, makes it easy for contributors to linting the code.
A local binary will be stored in the
./bin
folder to avoid collision with global installed Go modules.Which issue this PR fixes:
Untracked
Special notes for your reviewer:
Release notes: