kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

chore(golangci-lint): v1.54.2 pinning and config file #256

Closed prometherion closed 10 months ago

prometherion commented 10 months ago

What this PR does / why we need it:

Currently, there's no version pinning for the golangci-lint utility used, I had to manually retrieve it.

Rather, having it declared, makes it easy for contributors to linting the code.

A local binary will be stored in the ./bin folder to avoid collision with global installed Go modules.

Which issue this PR fixes:

Untracked

Special notes for your reviewer:

Release notes:

NONE
nunnatsa commented 10 months ago

@prometherion - #257 was just merged, bumping golang to version 1.20

Could you please try again with the latest version of golangci-lint?

qinqon commented 10 months ago

/retest

nunnatsa commented 10 months ago

/ok-to-test

nunnatsa commented 10 months ago

/hold

Need to run ci

@davidvossel I think there is a button for admins to allow ci to run. Could you please check?

nunnatsa commented 10 months ago

@prometherion, could you please update PR title with the right version of golangci-lint?

nunnatsa commented 10 months ago

/hold

Need to run ci

@davidvossel I think there is a button for admins to allow ci to run. Could you please check?

@agradouski @cchengleo - could you do that?

nunnatsa commented 10 months ago

/lgtm

@prometherion - the setting of this repo require one-time approval from an admin. This is why the github actions are not running. The funny thing is that it's is possible to merge even without it... Let's wait for one of the admins to approve you as a contributor.

qinqon commented 10 months ago

/approve

agradouski commented 10 months ago

/lgtm

nunnatsa commented 10 months ago

/approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, prometherion, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nunnatsa commented 10 months ago

/unhold