Fix "should succeed with the kubevirt cluster being deleted" unit test

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt

Apache License 2.0

108 stars 61 forks source link

Fix "should succeed with the kubevirt cluster being deleted" unit test #259

Closed nunnatsa closed 10 months ago

nunnatsa commented 10 months ago

What this PR does / why we need it

This unit test is broken. This PR fixes it by populating the KubevirtClusterReconciler.APIReader field in unit-test, for mocking.

In addition, this PR also fixes the hack/kccm-flavor-gen.sh script so it will replace the hard coded names with the right variables.

Which issue this PR fixes

fixes #258

Release notes:

None

nunnatsa commented 10 months ago

/ok-to-test

qinqon commented 10 months ago

/lgtm /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

agradouski commented 10 months ago

/lgtm thanks for fixing @nunnatsa