search

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Remove the setup counter from the KVMachine ready status #276

Closed nunnatsa closed 6 months ago

nunnatsa commented 6 months ago

What this PR does / why we need it

Cluster-API takes the reason and the message from the infra-machine (in our case, the KubeVirtMachine) Ready condition, into the cluster-api Machine's InfrastructureReady condition. Currently the text is something like "0 of 2 completed". This is not very informative.

This PR changes the behavior so now the KV Machine Ready condition will include both the reason and the message from the failed condition.

That way, the cluster-api InfrastructureReady condition, will also contain the same reason and message. This will make the actual issue, if exists, to more accessible to the user.

Release notes:

Remove the setup counter from the KV-Machine ready status
k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nunnatsa commented 6 months ago

/ok-to-test