Add new reason for failed vm

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt

Apache License 2.0

108 stars 61 forks source link

Add new reason for failed vm #280

Closed nunnatsa closed 2 months ago

nunnatsa commented 2 months ago

What this PR does / why we need it

Support DV's new ImagePullFailed reason. Set the machine reason to DVImagePullFailed.

Will only work after merging https://github.com/kubevirt/containerized-data-importer/pull/3194. Until then, the ols behavior will continue.

Release notes:

Support DV's new `ImagePullFailed` reason. Set the machine reason to `DVImagePullFailed`.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8705372106

Details

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 63.415%

Totals
Change from base Build 8167687188:	0.07%
Covered Lines:	1014
Relevant Lines:	1599

💛 - Coveralls

agradouski commented 2 months ago

/ok-to-test

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [davidvossel,nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment