kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
108 stars 61 forks source link

Remove e2e/go.mod #288

Closed nunnatsa closed 4 weeks ago

nunnatsa commented 1 month ago

e2e/go.mod was added to split the e2e into a new module, to allow using older k8s packages in e2e tests, because the new k8s packages conflicted with the KubeVirt go-client.

This PR replaces the KV go-client with a the kubernetes client, and so it is now possible to use the newest k8s packages, and in general, the same packages as the application uses.

Also made some smaller fixes and improvements in the e2e tests, related to contexes and assertions.

Release notes:

none
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/OWNERS)~~ [nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9395559512

Details


Totals Coverage Status
Change from base Build 9305462318: 0.0%
Covered Lines: 1548
Relevant Lines: 2611

💛 - Coveralls
nunnatsa commented 1 month ago

/ok-to-test

davidvossel commented 1 month ago

/retest