Allow e2e multiple times

kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt

Apache License 2.0

108 stars 61 forks source link

Allow e2e multiple times #289

Closed nunnatsa closed 4 weeks ago

nunnatsa commented 4 weeks ago

One of the e2e tests creates a secret that is not get deleted at the end of the test. When running the test again, it fails on secret re-creation.

This commit fixes the issue by deleting the secret at the end of each test.

Release notes:

None

nunnatsa commented 4 weeks ago

/ok-to-test

coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 9399394849

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.288%

Totals
Change from base Build 9305462318:	0.0%
Covered Lines:	1548
Relevant Lines:	2611

Pull Request Test Coverage Report for Build 9399423883

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.288%

Totals
Change from base Build 9305462318:	0.0%
Covered Lines:	1548
Relevant Lines:	2611

💛 - Coveralls

nunnatsa commented 4 weeks ago

/cc @davidvossel

k8s-ci-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[e2e/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/e2e/OWNERS)~~ [davidvossel,nunnatsa] - ~~[hack/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/hack/OWNERS)~~ [davidvossel,nunnatsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment