kubernetes-sigs / cluster-api-provider-kubevirt

Cluster API Provider for KubeVirt
Apache License 2.0
110 stars 63 forks source link

Base images for cluster nodes #89

Closed agradouski closed 2 years ago

agradouski commented 2 years ago

From CAPK community meeting discussion on Feb 1 (https://docs.google.com/document/d/1ZAnRLCKOVbDqrsrYis2OR0aZIAlqp576gCJVCkMNiHM), we need to find (or build and publish) a cluster node image, in order to truly unlock CAPK for developers. Also, it is a blocker for CAPK quick start guide.

Discussion points:

nirarg commented 2 years ago

This is related to this issue #84 @isaacdorfman can you also please start investigating kubernetes-sigs/image-builder project and see if that's something we can use to generate disk images that work for capk

wangxin311 commented 2 years ago

One comment: for CNI, we should leave it to user to choose just like other cloud provider doing for cluster api, end-user may not want or like built-in CNI provided us.

Here some of my experience on image-builder, FYI. I built a preliminary image based on kubernetes-sigs/image-builder for openstack cluster api months ago, it does generate qcow2 image and it should work for kubevirt because both are based on KVM underneath, I gave a try on kubevirt cluster api, seems it working, not well intensively tested but at least workload kubernetes cluster is up, however some parameter may need to tune for kubevirt cluster api user case.

agradouski commented 2 years ago

awesome, thanks for sharing @wangxin311

davidvossel commented 2 years ago

/assign @isaacdorfman

Isaac is working on this here, https://github.com/kubernetes-sigs/image-builder/pull/847

k8s-ci-robot commented 2 years ago

@davidvossel: GitHub didn't allow me to assign the following users: isaacdorfman.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/issues/89#issuecomment-1116239276): >/assign @isaacdorfman > >Isaac is working on this here, https://github.com/kubernetes-sigs/image-builder/pull/847 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/issues/89#issuecomment-1263788835): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.