search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

🐛Fix the issue of make release-notes in cluster-api-provider-nested #122

Closed fenglixa closed 3 years ago

fenglixa commented 3 years ago

I fixed related issue in CAPI by PR https://github.com/kubernetes-sigs/cluster-api/pull/4796. And this PR is fixing for the issue https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/118. After fixes, the cli make release-notes works well now:

 fenglixa@fenglixas-MacBook-Pro  ~/go/src/github.com/kubernetes-sigs/cluster-api-provider-nested   main ±  make release-notes
(unset)
cd hack/tools && go build -tags=tools -o bin/release-notes ./release
hack/tools/bin/release-notes
Changes since v0.1.0
---

_Thanks to all our contributors!_ 😊
 fenglixa@fenglixas-MacBook-Pro  ~/go/src/github.com/kubernetes-sigs/cluster-api-provider-nested   main ±  ll hack/tools/bin/release-notes
-rwxr-xr-x  1 fenglixa  staff  2484176 Jun 10 18:55 hack/tools/bin/release-notes

Fixes #118

k8s-ci-robot commented 3 years ago

Welcome @fenglixa!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-nested 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-nested has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 years ago

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fenglixa commented 3 years ago

/cc @gyliu513

fenglixa commented 3 years ago

/cc @christopherhein

christopherhein commented 3 years ago

/ok-to-test

christopherhein commented 3 years ago

/milestone v0.1.x

christopherhein commented 3 years ago

Thank you @fenglixa, appreciate you updating this! 🙏

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, fenglixa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment