kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

Correct the value for requestheader-client-ca-file #187

Closed jinsongo closed 3 years ago

jinsongo commented 3 years ago

What this PR does / why we need it: Correct the value for requestheader-client-ca-file parameter

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #185

k8s-ci-robot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 3 years ago

Welcome @wangjsty!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-nested 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-nested has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 years ago

Hi @wangjsty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jinsongo commented 3 years ago

@christopherhein @gyliu513 ^_^

gyliu513 commented 3 years ago

@wangjsty After apply the PR, I found apiserver report following error

I0720 10:38:29.054314       1 log.go:172] http: TLS handshake error from 10.244.0.1:55988: EOF
I0720 10:38:39.054815       1 log.go:172] http: TLS handshake error from 10.244.0.1:56122: EOF
I0720 10:38:49.055220       1 log.go:172] http: TLS handshake error from 10.244.0.1:56252: EOF
I0720 10:38:59.056103       1 log.go:172] http: TLS handshake error from 10.244.0.1:56376: EOF
jinsongo commented 3 years ago

@gyliu513 Yes, it's a problem, I'm fixing that.

gyliu513 commented 3 years ago

/ok-to-test

jinsongo commented 3 years ago

The error "http: TLS handshake error from 10.244.0.1:55988: EOF" can be recreated by following https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/docs/README.md, so it's nothing with the fix.

gyliu513 commented 3 years ago

/lgtm

/cc @Fei-Guo @christopherhein @charleszheng44

jinsongo commented 3 years ago

By the fix, the command "kubectl get packagemanifest -A" can work as expected for OLM.

christopherhein commented 3 years ago

This PR reminds me we need to get to writing e2e tests that we can run against a Kind cluster with prow sometimes so we don't get these things in main unseen. thank you for fixing this up!

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, wangjsty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment