search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

✨ Adding Support for Mutating DNSPolicy #254

Closed christopherhein closed 2 years ago

christopherhein commented 2 years ago

What this PR does / why we need it: This adds a feature gate that allows us to mutate the pods dnsPolicy using a label, removing the mutation that disallows setting ClusterFirst DNS.

Signed-off-by: Chris Hein me@chrishein.com

christopherhein commented 2 years ago

/assign @Fei-Guo @weiling61

christopherhein commented 2 years ago

Alright @Fei-Guo @weiling61 I updated this and moved the mutation tests out of the helpers and added a suite of tests for the DNS handling, I also notice @zhuangqh had a comment about adding more support so I added support for DNS Options to be passed through from tenant pods so that a user can customize settings like ndots or use-vc for using DNS over tcp.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, weiling61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment