search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

✨ Supporting Super Cluster Timeout Overrides #256

Closed christopherhein closed 2 years ago

christopherhein commented 2 years ago

What this PR does / why we need it: The default hardcoded 30 second timeout for the super cluster isn't enough under some scenarios, this allows that to be additionally supplied from a CLI flag but still uses the standard default if not supplied.

Signed-off-by: Chris Hein me@chrishein.com

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, weiling61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment