search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

🌱 Adding Timeout duration units #257

Closed christopherhein closed 2 years ago

christopherhein commented 2 years ago

What this PR does / why we need it: Follow up from - https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/256#discussion_r823165992

Signed-off-by: Chris Hein me@chrishein.com

christopherhein commented 2 years ago

/assign @Fei-Guo

Fei-Guo commented 2 years ago

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment