kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
299 stars 65 forks source link

Add DnsOption Flag to allow user to have customized resolve.conf #261

Closed weiling61 closed 2 years ago

weiling61 commented 2 years ago

What this PR does / why we need it: DnsOption needs to be entered by users according to their super cluster environment. Add flag to allow user to config DNSOptions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # N/A

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

weiling61 commented 2 years ago

@christopherhein

weiling61 commented 2 years ago

/retest

weiling61 commented 2 years ago

provider-nest-test seems not working properly

christopherhein commented 2 years ago

provider-nest-test seems not working properly

Did you check out what it says here - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-nested/261/pull-cluster-api-provider-nested-test/1506859629164892160

weiling61 commented 2 years ago

@christopherhein I checked test log, the file was not related to my change at all. Please check https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/264, this simple testing PR was also failed.

weiling61 commented 2 years ago

/retest

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, weiling61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment