Add Dnsoption flag - Githubissues

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters

Apache License 2.0

299 stars 65 forks source link

Add Dnsoption flag #263

Closed weiling61 closed 2 years ago

weiling61 commented 2 years ago

What this PR does / why we need it: Add dnsoption flag for user to enter more DNSOptions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # n/a

linux-foundation-easycla[bot] commented 2 years ago

:white_check_mark: login: weiling61 / name: Wei Ling (5fec10c507ad7b2c5bf6af83ac12981020bdc177, 4c2f7d86554270caa8d326c477a1c4b65d30d278, cece7fffc0505d1be48e8eb0664946ee3f7f6acf)
:x: The commit (3a3cdc76d80da8b2b0cd24b14328cb53b152367e, e5d1793899804f3e54a456d244b0091943ba1e98). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiling61 To complete the pull request process, please assign christopherhein after the PR has been reviewed. You can assign the PR to them by writing /assign @christopherhein in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

k8s-ci-robot commented 2 years ago

@weiling61: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-nested-test	cece7fffc0505d1be48e8eb0664946ee3f7f6acf	link	true	`/test pull-cluster-api-provider-nested-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).