Closed m-messiah closed 2 years ago
Hi @m-messiah. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@m-messiah I wonder since the conversion happens for all objects if it would make sense to make this a feature for all the resource syncers.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: christopherhein, m-messiah
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: The PR is a follow-up feature gate to SuperClusterLabelling https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/273. It adds new feature gate SuperClusterLabelFilter with namespace checker implementation to allow use label filter requesting super cluster namespaces, instead of doing the full list. It should reduce load to super cluster control plane in multi-platform super clusters (i.e. when super cluster itself is multi-tenant in addition to virtual clusters).