search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
298 stars 65 forks source link

✨ Add PersistentVolumeClaim status UWS #323

Closed wondywang closed 1 year ago

wondywang commented 1 year ago

What this PR does / why we need it:

Add PersistentVolumeClaim status upward sync. When we resize the storage of vPVC in VC, the CSI driver on the super cluster would update the pPVC.status.capacity after capacity expansion. Then we need to update vPVC status synchronously.

This time, we only consider the capacity update, and other information (such as accessModes and phase) will not be synchronized.

Which issue(s) this PR fixes:

Relate: #322

/kind feature

k8s-ci-robot commented 1 year ago

Hi @wondywang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wondywang commented 1 year ago

PTAL @christopherhein

Fei-Guo commented 1 year ago

/ok-to-test

Fei-Guo commented 1 year ago

1) Please change the copyright year of all touched/new files to 2022. 2) You need to modify the patroller to check the status consistency for PVC (can be in another PR if you prefer).

m-messiah commented 1 year ago

/assign @christopherhein

wondywang commented 1 year ago
  1. Please change the copyright year of all touched/new files to 2022.
  2. You need to modify the patroller to check the status consistency for PVC (can be in another PR if you prefer).

thx, have done.

Fei-Guo commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, m-messiah, wondywang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment