search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
298 stars 65 forks source link

🐛 Fix servcie mutator, reset pService ClusterIPs #327

Closed wondywang closed 1 year ago

wondywang commented 1 year ago

What this PR does / why we need it: When DWS sync service creating, spec.clusterIPs should be empty, just like clusterIP.

Which issue(s) this PR fixes : Fixes #325

wondywang commented 1 year ago

/retest

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, wondywang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wondywang commented 1 year ago

Nice work! 🤩

Thanks for your feedback @LuBingtan

ibmdcb commented 1 year ago

How can I try this fix? virtualcluster/syncer-amd64 on docker hub doesn't have this fix.