kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
298 stars 65 forks source link

🌱 Adding Cluster Labels w/ Control Plane Components #331

Closed christopherhein closed 1 year ago

christopherhein commented 1 year ago

What this PR does / why we need it: This adds cluster labels to the tenant controlplane components to help with reporting all components/pods used for the cluster. We also use this to configure pod level networking so that Control Planes can have routable services from the APIServer.

Signed-off-by: Chris Hein me@chrishein.com

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wondywang commented 1 year ago

/LGTM