search

kubernetes-sigs / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
298 stars 65 forks source link

🌱 Update feature-gate util #335

Closed wondywang closed 1 year ago

wondywang commented 1 year ago

What this PR does / why we need it:

As a developer, when more and more feature gates are going to support, there will be some differences between different Syncer versions. In order to check the feature gate supported by a specific version, we hope to support --help to display all supported feature gates at current version.

it will output like this:

 $./syncer --help
The resource syncer is a daemon that watches tenant clusters to
keep tenant requests are synchronized to super cluster by creating corresponding
custom resources on behalf of the tenant users in super cluster.

Usage:
  syncer [flags]

Server flags:

      --feature-gates mapStringBool
                A set of key=value pairs that describe feature gates for various features.Options are:
                ClusterVersionPartialUpgrade=true|false (default=false)
                DisableCRDPreserveUnknownFields=true|false (default=false)
                RootCACertConfigMapSupport=true|false (default=false)
                SuperClusterLabelFilter=true|false (default=false)
                SuperClusterLabelling=true|false (default=false)
                SuperClusterPooling=true|false (default=false)
                SuperClusterServiceNetwork=true|false (default=false)
                TenantAllowDNSPolicy=true|false (default=false)
                TenantAllowResourceNoSync=true|false (default=false)
                VNodeProviderPodIP=true|false (default=false)
                VNodeProviderService=true|false (default=false)
                VServiceExternalIP=true|false (default=false) (default SuperClusterPooling=false,SuperClusterServiceNetwork=false,VNodeProviderService=false)

Which issue(s) this PR fixes: Fixes #

wondywang commented 1 year ago

/retest

christopherhein commented 1 year ago

this is great work @wondywang ! Do you feel good about merging this, code looks good from my view.

wondywang commented 1 year ago

this is great work @wondywang ! Do you feel good about merging this, code looks good from my view.

Thx @christopherhein , I think this will benefit our daily devops. Please merge this code. :rose:

christopherhein commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, wondywang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment